Streamline installation, upgrades, and first-run setup - #329
Conversation
There was a problem hiding this comment.
Pull request overview
Adds mise installation documentation and delegates upgrades for mise-managed binaries.
Changes:
- Detects mise ownership and updates the active mise configuration.
- Supports pinned and prerelease versions with post-upgrade verification.
- Adds mise upgrade tests and documentation.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
README.md |
Documents mise installation and upgrade behavior. |
internal/cmd/upgrade.go |
Implements mise detection, delegation, and verification. |
internal/cmd/upgrade_test.go |
Tests mise upgrade and ownership scenarios. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
|
Addressed both inline review comments in f55ee50: pinned mise upgrades now confirm the exact requested version, and recovery commands shell-quote configuration paths safely. |
bbfcc64 to
936dfdd
Compare
robzolkos
changed the title
e518c52 to
547ccb3
Compare
ad17ab5 to
62af178
Compare
Review fixes for hey setup agents --remove and its docs: - removeOwnedSkillFiles now Lstats the directory and declines a symlink or non-directory the way every other skill write path does (claimSkillDir, writeSkillFile), so removal can never delete managed files through a user's symlink target. A real Lstat failure surfaces as an error instead of a silent skip. - Cover the setup_remove_failed failure aggregation: a failing `claude plugin uninstall` and a missing claude binary both name the failing component in the error, and the symlink refusal keeps the target's files intact. - docs/omarchy.md no longer promises a literal "Step 3" now that wizard step numbers are assigned dynamically to the steps that actually run.
62af178 to
0612a03
Compare
Intent
Make HEY straightforward to install and set up from start to finish, while respecting package-manager ownership and leaving optional integrations under the user’s control.
Changes
hey setupconfigure detected agents and Omarchy automaticallyTesting
GOWORK=off go test ./internal/...GOWORK=off make lintbats tests/e2e/installer.bats— 39 passing